Submission Details
Severity:
Missing `deadline` check in `receive` function
Summary:
`ChristmasDinner::receive` function does not checks the deadline for the user who are participating by depositiong ETH.
Impect:
Anyone can participate after deadline.
Proof of concept:
Add this into `ChristmasDinnerTest.t.sol`
Code:
```javascript
function testUserCanDepositeAfterDeadline() public {
vm.deal(user1, 10e18);
vm.warp(1 + 8 days);
vm.startPrank(user1);
(bool ok, ) = address(cd).call{value: 1e18}("");
vm.stopPrank();
assert(ok);
}
```
Recommendations:
The `receive` frunction should be like
```diff
receive() external payable {
+ if(block.timestamp > deadline) {
+ revert BeyondDeadline()
+ }
etherBalance[msg.sender] += msg.value;
emit NewSignup(msg.sender, msg.value, true);
}
```
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
receive() function independant from deadline
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.