Submission Details
Severity:
ChristmasDinner:locked is never set, causing all non reentrancy checks to be disabled
Summary
The ChristmasDinner::nonReentrant modifier fails to set the ChristmasDinner:locked variable to true, resulting in the modifier having no effect other than consuming gas.
Impact
ChristmasDinner:refund is not protected against reentrancy attack.
Tools Used
Recommendations
Add the following line in the modifier:
modifier nonReentrant() {
require(!locked, "No re-entrancy");
+ locked = true;
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.