Submission Details
Severity:
Deadline can still be updated even after it has been set
Summary
The setDeadline() function can still be called even after deadline has been set due to an incorrect logic error, and going against the function's intended design
Vulnerability Details
The function is not updating the deadlineStatus
to true after it has been set, making room to extend or shorten deadlines.
Impact
Unpredictable behavior or malicious misuse by the host, such as extending the deadline indefinitely to allow or prevent additional participants.
Tools Used
Manual Review, Foundry
Recommendations
we update the deadlineStatus after the function is called
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
+ deadlineSet = true;
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.