Submission Details
Severity:
The `ChristimasDinner:deposit` doesn't allow users to signup for other users causing natspec incorrect.
Summary
/*
* @dev handles the deposit logic. Supposed to only let deposits of whitelisted tokens happen.
* Supposed to not accept deposits after deadline. Allows multiple deposits of a user as generous extra contribution.
@> * Allows a user to sign-up other users.
*
*/
function deposit(address _token, uint256 _amount) external beforeDeadline {
.
.
.
}
The deposit
ChristimasDinner:depositfunction says that it allows a user to sign-up for other users but the function doesn't have any logic to implement it.
Impact
The NatSpec documentation is incorrect, which could mislead developers or auditors reading the code.
Tools Used
Recommendations
Remove the incorect natspec line.
* @dev handles the deposit logic. Supposed to only let deposits of whitelisted tokens happen.
* Supposed to not accept deposits after deadline. Allows multiple deposits of a user as generous extra contribution.
- * Allows a user to sign-up other users.
* Assumes that no weird ERC20s or any ERC20s outside the whitelisted tokens need to be handled.
* Assumes general trust relationship between the users of this contract.
* Does not allow signing up with Ether, for Ether signups use receive()
* @param _token the token the user wishes to deposit
* @param _amount the amount the user wishes to contribute
*/
function deposit(address _token, uint256 _amount) external beforeDeadline {
.
.
.
}
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.