Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

The `ChristimasDinner:_refundERC20` NatSpec Assumes No Re-Entrancy, but Re-Entrancy Is Possible

Impact

  • The NatSpec documentation is incorrect, which could mislead developers or auditors reading the code.

Tools Used

  • Foundry

Recommendations

  • Remove the incorect natspec line.

/**
- * @dev ERC20 withdrawal of all user funds. No concern for Reentrancy
+ * @dev ERC20 withdrawal of all user funds.
* since refund() uses a Mutex Lock
* @param _to payable address passed from refund()
*/
function _refundERC20(address _to) internal {
i_WETH.safeTransfer(_to, balances[_to][address(i_WETH)]);
.
.
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.