Submission Details
Severity:
The `ChristmasDinner::refund` function does not update the `participant` mapping, allowing users to participate even if they already received a refund.
Description
The ChristmasDinner::refund function never updates the participant mapping of the user requesting the refund.
Impact
One impactul scenario is when users who have already requested a refund may still attend the dinner for free.
Proof of Concepts
Recommended mitigation
Add the following change to the code.
function refund() external nonReentrant beforeDeadline {
+ participant[msg.sender] = false;
address payable _to = payable(msg.sender);
_refundERC20(_to);
_refundETH(_to);
emit Refunded(msg.sender);
}
Updates
Lead Judging Commences
0xtimefliez 10 months ago
Submission Judgement Published Assigned finding tags:
refund does not update participation status
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.