Submission Details
Severity:
The `ChristmasDinner::deadlineSet` is never updated to `true` when calling `ChristmasDinner::setDeadline`, allowing multiple change of deadlines.
Description
The global variable ChristmasDinner::deadlineSet is not updated to true when setting the deadline by calling ChristmasDinner::setDeadline.
Impact
The contract allows multiple change of deadlines.
Proof of Concepts
The test ChristmasDinnerTest::test_tryResettingDeadlineAsHost already proves that the deadline can be updated by calling the function ChristmasDinner::setDeadline more than once.
Recommended mitigation
Add the following change to the code.
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
+ deadlineSet = true;
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez 8 months ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.