Submission Details
Severity:
The `ChristmasDinner::_refundETH` function uses `transfer()` instead of `call()`.
Description
The function ChristmasDinner::_refundETH in charge of refunding the ETH uses transfer() instead of call().
Impact
Depending on the user (if decided to participate using a smart contract wallet), the use of transfer might render ETH impossible to withdraw due to the 2300 forwarded gas limitation.
Proof of Concepts
Recommended mitigation
Add the following change to the code.
function _refundETH(address payable _to) internal {
uint256 refundValue = etherBalance[_to];
+ _to.call{value: refundValue}("");
- _to.transfer(refundValue);
etherBalance[_to] = 0;
}
Updates
Lead Judging Commences
0xtimefliez 8 months ago
Submission Judgement Published Assigned finding tags:
transfer instead of call
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.