Wrong Uplift Fee Take
Summary
In UpdateWeightRunner we should have both quantAMMUpliftFeeTake and quantAMMSwapFeeTake. However, currently that is not the case.
Vulnerability Details
Setting quantAMMUpliftFeeTake is currently setting quantAMMSwapFeeTake and fetching it is fetching also the swap fee take which should not be the case.
Impact
Confusion of the fee structure and also wrong accounting of quantAMMSwapFeeTake when it is changed from setQuantAMMUpliftFeeTake.
Tools Used
Manual Review
Recommendations
Add the quantAMMUpliftFeeTake and fix the functionality of setting it and fetching it.
Lead Judging Commences
finding_quantAMMSwapFeeTake==quantAMMUplfitFeeTake
Likelyhood: High, calling setters or getters Impact: Low/Medium, both getters return `quantAMMSwapFeeTake` and `setQuantAMMUpliftFeeTake` modify `quantAMMUplfitFeeTake`. Real impact: those 2 values will be always the same.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.