Summary

The divideNft function redundantly applies the onlyNftOwner modifier twice for the same parameters. This duplication serves no additional security purpose, as the modifier is already ensuring the sender is the owner of the specified nftAddress and tokenId. This results in unnecessary gas consumption and an inefficient implementation.

Vulnerability Details

Impact

1. Each call to the onlyNftOwner modifier introduces additional gas consumption.

2. Users calling this function will incur higher transaction costs.

Tools Used

Manual

Recommendation

Apply only single check in this function.