Submission Details
Severity:
Redundant Address Zero Check in transferErcTokens Function
Summary
The transferErcTokens function redundantly checks if the to address is zero (address(0)) twice. This duplication is unnecessary, as a single check is sufficient to validate the input. This redundancy increases gas consumption and reduces code efficiency without providing any additional functionality.
Vulnerability Details
function transferErcTokens(address nftAddress,address to, uint256 amount) external {
if(nftAddress == address(0)) {
revert TokenDivider__NftAddressIsZero();
}
--> if(to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
if(amount == 0) {
revert TokenDivider__AmountCantBeZero();
}
ERC20Info memory tokenInfo = nftToErc20Info[nftAddress];
--> if(to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
Impact
Each additional check consumes unnecessary gas.
Users calling this function will pay more in transaction fees.
Tools Used
Manual
Recommendations
Use only one check
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.