Part 2

Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Submission Details
Severity: medium
Invalid

Storage Collision Risk in _getFeeConversionKeeperStorage()

Summary

https://github.com/Cyfrin/2025-01-zaros-part-2/blob/main/src/external/chainlink/keepers/fee-conversion-keeper/FeeConversionKeeper

Vulnerability Details

Uses assembly to manually assign storage slots.

Impact

If the contract is upgraded, this can lead to storage slot corruption, causing critical state inconsistencies.

Tools Used

Manual Review

Recommendations

Use StorageSlot.getUint256Slot() from OpenZeppelin instead.

Updates

Lead Judging Commences

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.