Part 2
Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing Events for Important Updates

m3ntor

Summary

https://github.com/Cyfrin/2025-01-zaros-part-2/blob/main/src/external/chainlink/keepers/fee-conversion-keeper/FeeConversionKeeper

Vulnerability Details

updateConfig() modifies marketMakingEngine and minFeeDistributionValueUsd but does not emit an event.

Impact

This makes tracking contract changes difficult.

Tools Used

Manual Review

Recommendations

Add an event like:

event ConfigUpdated(address indexed marketMakingEngine, uint128 minFeeDistributionValueUsd);

Emit it inside updateConfig().

Updates

Lead Judging Commences

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.