Submission Details
Severity:
Rounding Not Used
Summary
In ZlpVault rounding of _convertToShares is not used, getVaultAssetSwapRate always uses floor rounding. Consider passing it down to the function and using the specified rounding. Same applies for _convertToAssets
Impact
Wrong rounding in the mentioned functions.
Tools Used
Manual Review
Recommendations
Use the rounding specified in the call to the given functions instead of always using a floor rounding.
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821
USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.