Submission Details
Severity:
Distribution Only Performed When `assetValue` Greater Than `minFeeDistributionValueUsd`
Summary
In FeeConversionKeeper::checkFeeDistributionNeeded won't perform distribution when assetValue is equal to minFeeDistributionValueUsd, only when greater. This is a problem as the minimum should be a valid value for a distribution to be triggered.
Impact
Wrong check for fee distribution trigger.
Tools Used
Manual Review
Recommendations
Change the function in the following way:
function checkFeeDistributionNeeded(
address asset,
uint256 collectedFee
)
public
view
returns (bool distributionNeeded)
{
// load keeper data from storage
FeeConversionKeeperStorage storage self = _getFeeConversionKeeperStorage();
/// get asset value in USD
uint256 assetValue = self.marketMakingEngine.getAssetValue(asset, collectedFee);
// if asset value GT min distribution value return true
- distributionNeeded = assetValue > self.minFeeDistributionValueUsd;
+ distributionNeeded = assetValue >= self.minFeeDistributionValueUsd;
}
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821
USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.