DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Lack of Access Control on MultiSigWallet.receive

  • Root Cause: The MultiSigWallet contract has a receive() function that allows it to receive ETH. While this is necessary for receiving the match rewards, it lacks access control.

  • Impact: Potential for accidental or malicious transfer of ETH to the MultiSigWallet that isn't related to match rewards.

  • Recommendation: Restrict the receive() function to only allow transfers from the LikeRegistry contract.
    modifier onlyLikeRegistry() {
    require(msg.sender == address(likeRegistry), "Only LikeRegistry can send ETH");
    _;
    }

    receive() external payable onlyLikeRegistry {}

Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_receive_function

Not the best design, but if you send money accidentally, that's a user mistake. Informational.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.