DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Inefficient String Manipulation in SoulboundProfileNFT.tokenURI

  • Root Cause: The tokenURI function constructs the JSON metadata string using string concatenation with abi.encodePacked. While this works, it can be gas-intensive, especially as the metadata grows larger.

  • Impact: High gas costs for retrieving token metadata.

  • Recommendation: Consider using a more gas-efficient method for constructing JSON strings, such as a dedicated library for JSON generation or storing the metadata off-chain (IPFS) and referencing it in the tokenURI.

Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.