DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: medium
Invalid

FIXEDFEE Is Hardcoded and Cannot Be Changed

FIXEDFEE Is Hardcoded and Cannot Be Changed

Description:

The contract sets FIXEDFEE = 10, meaning the fee percentage is hardcoded and immutable. If the team ever wants to change it, they must deploy a new contract.

Impact:

No flexibility to adjust fees if market conditions change.
Requires a full contract redeployment just to update the fee percentage.

Recommended Mitigation:

Replace FIXEDFEE with a mutable variable that the owner can update:

✅ Fixed Code:

uint256 public fixedFee = 10; // ✅ Now mutable
function setFixedFee(uint256 newFee) external onlyOwner {
require(newFee <= 50, "Fee too high"); // ✅ Prevent excessive fees
fixedFee = newFee;
}
Updates

Appeal created

n0kto Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.