DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Potential use of `tx.origin` for authentication

Summary:

Use of tx.origin for authentication in GmxProxy:setPrepVault which set the transaction address instead of owner

Vulnerability Details:

- Found in contracts/GmxProxy.sol [Line: 352](contracts/GmxProxy.sol#L352)

require(tx.origin == owner(), "not owner");

Impact:

Using `tx.origin` may lead to problems when users are interacting via smart contract with your protocol

Tools Used:

Manual review+aderyn+slither

Recommendations:

It is recommended to use msg.sender for authentication instead of tx.origin

- require(tx.origin == owner(), "not owner");
+ require(msg.sender == owner(), "not owner");
Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

invalid_tx-origin

Lightchaser: Medium-5

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.