Liquidity Management
Gamma
DeFiFoundry
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Deprecated OpenZeppelin functions should not be used

nepker

Summary:

Deprecated OpenZeppelin functions should not be used in the function GmxProxy:createOrder

Vulnerability Details:

- Found in contracts/GmxProxy.sol [Line: 406](contracts/GmxProxy.sol#L406)

IERC20(fromToken).safeApprove(approvalAddress, fromAmount);

Impact:

Deprecated OpenZeppelin function leads to the damage of the smart contract.

safeApprove() was deprecated because it can lead to transaction failures in certain scenarios, particularly when trying to modify an existing non-zero allowance. This can cause transactions to revert unexpectedly.

Tools Used:

Manual review + static analysis using aderyn+ slither

Recommendations:

Use safeIncreaseAllowance instead of safeApprove in GmxProxy:createOrder function

Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Appeal created

nepker Submitter
7 months ago
n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.