DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

`cancelFlow()` is never callable due to "acceidents" on GMX's side

Summary

cancelFlow()is never callable due to accidents on GMX's side due to the gmxLockwhich might limit its useability for canceling flows.


Vulnerability Details

In the @dev documents, it states:

/**
* @notice
* Cancel the current ongoing flow.
* @dev
* In the case of 1x long leverage, we never cancel the ongoing flow.
* In the case of gmx position, we could cancel current ongoing
* flow due to some accidents from our side or gmx side.
*/

However, due to the gmxLockit will never be callable during an ongoing created order on the GMX side, therefore hindering the possibility to cancel the flow if needed.

Impact

Low

Tools Used

Manual Review.

Recommendations

Consider if the gmxLockis necessary.

Updates

Lead Judging Commences

n0kto Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.