Title

Missing execution check in GmxProxy contract causes operational halts

Summary

A missing feature check in the settle function of the GmxProxy contract could cause the protocol to stop working if the GMX execution feature is disabled. This issue needs to be addressed to prevent service disruptions.

Vulnerability Details

The settle function currently lacks a necessary check to ensure the GMX order execution feature is enabled. This is the same kind of issue that was previously identified in the createOrder function during an earlier audit. The absence of this check in settle can cause orders to be created successfully but not executed, leading to operational problems.

The required check should look like this:

Without this check, the protocol could face disruptions even though the issue was previously identified.

Impact

If the GMX execution feature is disabled while this vulnerability exists, orders will not be executed. This could lead to stalled operations that won't resume until the feature is re-enabled, requiring manual intervention like cancelling orders.

Tools Used

• manual code review

• comparison with previous audit findings

Recommendations

Add the missing GMX feature check to the settle function.