Liquidity Management
Gamma
DeFiFoundry
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

L-2 Missing Handling for Undefined Order Types in getExecutionGasLimit()

radcipher

Summary

  • If orderType is not one of the expected types, estimatedGasLimit remains uninitialized (zero).

function getExecutionGasLimit(
Order.OrderType orderType,

Impact

  • This could lead to an underestimation of gas or unexpected behavior.

  • If the case is that estimatedGasLimit remains uninitialized (zero), this could cause transactions to fail due to insufficient gas estimates.

Tools Used

  • Manual review

Recommendations

  • Add a fallback for unexpected order types

Updates

Lead Judging Commences

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Too generic
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.