Code structure in GmxProxy.sol::lowerThanMinEth()
Summary
The GmxProxy.sol::lowerThanMinEth() contains unnecessary else block that doesn't add additional functionality or clarity to the code.
Vulnerability Details
The logic inside the else block simply returns a boolean value (true) if the ifcondition is false. This results in redundant code, as it could be replaced by a straightforward returnstatement.
Impact
While the presence of the elseblock does not introduce a direct vulnerability, it does slightly reduce code clarity and readability.
Recommendations
The else block can be removed without affecting the functionality of the code.
Lead Judging Commences
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.