DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

The `setMinMaxDepositAmount` function does not validate the conditions of `_minDepositAmount` and `_maxDepositAmount` when setting their values.

Summary

In the documentation, the values are specified as minDepositAmount = 1000 and maxDepositAmount = 100000. However, the setMinMaxDepositAmount function does not validate these values, allowing the Owner to set minDepositAmount and maxDepositAmount to any value.

Vulnerability Details

In the setMinMaxDepositAmount function not validate _minDepositAmount and _maxDepositAmount

function setMinMaxDepositAmount(uint256 _minDepositAmount, uint256 _maxDepositAmount) external onlyOwner {
minDepositAmount = _minDepositAmount;
maxDepositAmount = _maxDepositAmount;
}

Owner can set minDepositAmount = 0 and maxDepositAmount = 0 Or can set minDepositAmount > maxDepositAmount , As such these values ​​will differ from the conditions in the description document.

Impact

Setting the wrong value can affect the contract and the minDepositAmount, maxDepositAmount check conditions.

Tools Used

Manual

Recommendations

Add validate _minDepositAmount and _maxDepositAmount

if (_minDepositAmount >= _maxDepositAmount) {
revert Error.WrongValue();
}
if (_minDepositAmount < 1000) {
revert Error.WrongValue();
}
if (_maxDepositAmount > 100000) {
revert Error.WrongValue();
}
Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Admin is trusted / Malicious keepers

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point. Keepers are added by the admin, there is no "malicious keeper" and if there is a problem in those keepers, that's out of scope. ReadMe and known issues states: " * System relies heavily on keeper for executing trades * Single keeper point of failure if not properly distributed * Malicious keeper could potentially front-run or delay transactions * Assume that Keeper will always have enough gas to execute transactions. There is a pay execution fee function, but the assumption should be that there's more than enough gas to cover transaction failures, retries, etc * There are two spot swap functionalies: (1) using GMX swap and (2) using Paraswap. We can assume that any swap failure will be retried until success. " " * Heavy dependency on GMX protocol functioning correctly * Owner can update GMX-related addresses * Changes in GMX protocol could impact system operations * We can assume that the GMX keeper won't misbehave, delay, or go offline. " "Issues related to GMX Keepers being DOS'd or losing functionality would be considered invalid."

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Admin is trusted / Malicious keepers

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point. Keepers are added by the admin, there is no "malicious keeper" and if there is a problem in those keepers, that's out of scope. ReadMe and known issues states: " * System relies heavily on keeper for executing trades * Single keeper point of failure if not properly distributed * Malicious keeper could potentially front-run or delay transactions * Assume that Keeper will always have enough gas to execute transactions. There is a pay execution fee function, but the assumption should be that there's more than enough gas to cover transaction failures, retries, etc * There are two spot swap functionalies: (1) using GMX swap and (2) using Paraswap. We can assume that any swap failure will be retried until success. " " * Heavy dependency on GMX protocol functioning correctly * Owner can update GMX-related addresses * Changes in GMX protocol could impact system operations * We can assume that the GMX keeper won't misbehave, delay, or go offline. " "Issues related to GMX Keepers being DOS'd or losing functionality would be considered invalid."

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.