Submission Details
Severity:
Improper Validation of Fee Amount in collectFee on FeeCollector.sol
Summary
The collectFee function does not check if the fee amount exceeds the available balance in the contract. This could allow users to collect more tokens than are available in the contract.
Vulnerability Details
raacToken.safeTransferFrom(msg.sender, address(this), amount);
Impact
This could lead to an overdraw of the contract balance, causing issues in distributing fees or paying rewards.
Tools Used
Recommendations
Validate that the contract has enough balance before transferring tokens from the sender. This ensures that the contract does not accumulate more fees than it can distribute.
uint256 contractBalance = raacToken.balanceOf(address(this));
if (amount > contractBalance) revert InsufficientBalance();
raacToken.safeTransferFrom(msg.sender, address(this), amount);
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.