Submission Details
Severity:
Incorrect FeeType percentages.
Summary
The _initializeFeeTypes function sets incorrect percentages for feeTypes[6] and feeTypes[7].
Vulnerability Details
The last 2 feeTypes are configured the following way:
feeTypes[6] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 500, // 0.5%
repairShare: 1000, // 1.0%
treasuryShare: 0
});
// NFT Royalty Fees (2% total)
feeTypes[7] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 0,
repairShare: 1000, // 1.0%
treasuryShare: 500 // 0.5%
});
But given that basis points is 10000 (100%), 500 is actually 5% and 1000 is 10%.
Impact
10x more spent in fees for those 2 fee types.
Tools Used
Manual review.
Recommendations
Cange 500 to 50 and 1000 to 100 in those configurations.
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.