Submission Details
Severity:
`amountWithdrawn` is never returned
https://github.com/Cyfrin/2025-02-raac/blob/main/contracts/libraries/pools/ReserveLibrary.sol#L383
From our withdraw function we expect it to return an amountWithdrawn from the function signature
function withdraw(
ReserveData storage reserve,
ReserveRateData storage rateData,
uint256 amount,
address recipient
) internal returns (uint256 amountWithdrawn, uint256 amountScaled, uint256 amountUnderlying) {} // logic omitted for simplicity
As shown we expect an amount withdrawn to be returned.
The amountWithdrawn is later assigned to the burned scaled amount below
amountWithdrawn = burnedScaledAmount;
However, looking at the return values
return (amountUnderlying, burnedScaledAmount, amountUnderlying);
amountWithdrawn is never returned as expected.
Impact
Wrong amountWithdrawn value
Recommendation
Return values should contain an amountWithdrawn
Updates
Lead Judging Commences
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
ReserveLibrary::withdraw returns amountUnderlying instead of amountWithdrawn, causing incorrect event emissions and potential calculation errors in LendingPool
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
ReserveLibrary::withdraw returns amountUnderlying instead of amountWithdrawn, causing incorrect event emissions and potential calculation errors in LendingPool
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.