Submission Details
Severity:
If `amountToMint == 0` the return values are wrong
overview
It is expected that when a user tries to send amount as O, the function returns thhe following values
if (amountToMint == 0) {
return (false, 0, 0, 0);
}
the return values should be
(bool isFirstMint, uint256 amountScaled, uint256 newTotalSupply, uint256 amountUnderlying) = IRToken(reserve.reserveRTokenAddress).mint(
address(this), // caller
depositor, // onBehalfOf
amount, // amount
reserve.liquidityIndex // index
);
it includes values like newTotalSupply which are all set to 0. This means a total Supply of 0 could be sent which is wrong
Impact
wrong return values
Recommendation
Return the actual total Supply totalSupply() and also check the other values and ensure you return accurate values.
Updates
Lead Judging Commences
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
RToken::mint returns 0 instead of actual totalSupply() when amountToMint is 0, causing incorrect data for off-chain systems relying on return values
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
RToken::mint returns 0 instead of actual totalSupply() when amountToMint is 0, causing incorrect data for off-chain systems relying on return values
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.