Submission Details
Severity:
Wrong use of negation in TimelockController::scheduleBatch
Vulnerability Details
This line is supposed to check if the predecessor is executed or not, but the wrong use of negation will make the function revert even if the predecessor is executed.
Impact
scheduleBatch function will revert even if the predecessor is executed.
Tools Used
Manual Review
Recommendations
--- if (!isOperationDone(predecessor) && !isOperationPending(predecessor)) {
+++ if (!isOperationDone(predecessor) && isOperationPending(predecessor)) {
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
TimelockController::scheduleBatch checks if predecessor is pending OR executed rather than requiring execution as per comment, allowing scheduling before predecessor executes
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
TimelockController::scheduleBatch checks if predecessor is pending OR executed rather than requiring execution as per comment, allowing scheduling before predecessor executes
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.