Core Contracts

Summary

The increase function lacks proper supply cap verification when adding tokens to existing locks, potentially allowing the total supply to exceed the MAX_TOTAL_SUPPLY limit. This oversight in supply management could compromise the token's economic model.

Vulnerability Details

While the lock function properly implements a supply cap check:

The increase function omits this crucial verification step. Users can potentially circumvent the MAX_TOTAL_SUPPLY restriction by incrementally increasing their locked amounts.

Impact

• Total veRAAC token supply could exceed MAX_TOTAL_SUPPLY, undermining supply constraints

• Potential economic implications for governance and token utility mechanisms

Tools Used

• Manual code review

Recommendations

1. Implement supply cap validation in the increase function:

   if (totalSupply() + amount > MAX_TOTAL_SUPPLY) revert TotalSupplyLimitExceeded();