DeFiLayer 1Layer 2
14,723 OP
View results
Submission Details
Severity: low
Invalid

## Low Severity Findings ###

1. Redundant Import Statements

File: ScrvusdVerifierV2.sol
Line: 6
Code:

import {RLPReader} from "hamdiallam/Solidity-RLP@2.0.7/contracts/RLPReader.sol";

Description: The RLPReader library is imported but not utilized within the contract, leading to unnecessary code inclusion and potential confusion.

Remediation: Remove unused import statements to streamline the codebase and improve readability.

2. Magic Numbers in Code

File: ScrvusdVerifierV2.sol
Line: 31
Code:

uint256 internal PERIOD_SLOT = 37; // profit_max_unlock_time

Description: The use of magic numbers (e.g., 37) without context can make the code harder to understand and maintain.

Remediation: Define such numbers as constants with descriptive names or add comments to explain their significance.

Updates

Lead Judging Commences

0xnevi Lead Judge
3 months ago
0xnevi Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.