Submission Details
Severity:
Owner can change eggFindTreshhold during game
Summary
Owner can change the eggFindThreshold at any desired time, while game is active or not active
Vulnerability Details
This can help certain players to take advantage of periods when eggFindThreshold is set to a high value and eggs are easier to find
Impact
Can lead to unfair results
Tools Used
Forge Test, Remix, Manual Review
Recommendations
Restrict setting a new eggFindThreshold only to times when the game is not active
/// @notice Allows the owner to adjust the egg-finding chance.
function setEggFindThreshold(uint256 newThreshold) external onlyOwner {
require(newThreshold <= 100, "Threshold must be <= 100");
require(!gameActive, "Can not change value when game is active"); // Restrict changing the value only to times when game is not active
eggFindThreshold = newThreshold;
}
Updates
Lead Judging Commences
m3dython 4 months ago
Submission Judgement Published Reason: Design choice
Assigned finding tags:
Trusted Owner
Owner is trusted and is not expected to interact in ways that would compromise security
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.