Submission Details
Severity:
The EggVault.depositEgg method needs to add permission check
Summary
The EggVault.depositEgg method needs to add permission check
Vulnerability Details
The EggVault.depositEgg method lacks permission check
Impact
If the user accidentally sends the nft directly to the Vault, the attacker can steal it directly.
Tools Used
Recommendations
....
++++EggHuntGame public eggHuntGame;
....
function depositEgg(uint256 tokenId, address depositor) public {
+++ require(msg.sender == eggHuntGame,"");
require(eggNFT.ownerOf(tokenId) == address(this), "NFT not transferred to vault");
require(!storedEggs[tokenId], "Egg already deposited");
storedEggs[tokenId] = true;
eggDepositors[tokenId] = depositor;
emit EggDeposited(depositor, tokenId);
}
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.