Submission Details
Severity:
Lack of Input Validation in Game Creation
Description: The RockPaperScissors::createGameWithEth() and RockPaperScissors::createGameWithToken() functions don't validate the _timeoutInterval parameter against a maximum value.
Impact: Players could set excessively long timeout intervals, potentially locking funds in the contract for extended periods.
Proof of Concept:
function createGameWithEth(uint256 _totalTurns, uint256 _timeoutInterval) external payable {
// ... existing code ...
require(_timeoutInterval >= 5 minutes, "Timeout must be at least 5 minutes");
// No maximum timeout check
}
Recommended Mitigation: Add a maximum timeout value check, e.g., require(_timeoutInterval <= 24 hours, "Timeout too long");
Rewards breakdown
nSLOC
349This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.