Submission Details
Severity:
Potential Reentrancy in Token Transfers
Description: The contract uses RockPaperScissors::transferFrom for token transfers without following the checks-effects-interactions pattern.
Impact: While unlikely due to the simple nature of the transfers, there's a theoretical risk of reentrancy attacks.
Proof of Concept:
function joinGameWithToken(uint256 _gameId) external {
// ... existing code ...
winningToken.transferFrom(msg.sender, address(this), 1);
game.playerB = msg.sender;
emit PlayerJoined(_gameId, msg.sender);
}
Recommended Mitigation: Follow the checks-effects-interactions pattern by updating state before making external calls.
Rewards breakdown
nSLOC
349This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.