Submission Details
Severity:
System Upgrade Proceeds Without Valid Session End or Complete Reviews
Summary
The system currently allows graduateAndUpgrade() to proceed without verifying that each student has received all 4 reviews. This breaks the integrity of the school lifecycle, where graduation and upgrades should only occur after full evaluation.
Vulnerability Details
Impact
Students may graduate without proper evaluation.
Tools Used
manual review
Recommendations
Add a loop to verify all students have received 4 reviews:
for (uint256 i = 0; i < listOfStudents.length; i++) {
if (studentReviews[listOfStudents[i]].length != 4) {
revert IncompleteStudentReviews(listOfStudents[i]);
}
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
cut-off criteria not applied
All students are graduated when the graduation function is called as the cut-off criteria is not applied.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.