Submission Details
Severity:
[L-1] Emitting event is missing in `LevelOne::graduateAndUpgrade`, which will not notify for the updated values.
Summary
After each change to the protocol, an event is emited that notifies users or other systems that are listening for these events. We do not emit the “Graduated” event and it will not notify about ongoing changes. Since this is an important thing and needs to be announced that the contract has a new implementation, this can mislead users.
Impact
Not make sure that users and systems related with the protocol are aware of the upgrade.
Tools Used
Manual Review
Recommendations
function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
uint256 totalTeachers = listOfTeachers.length;
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
_authorizeUpgrade(_levelTwo);
for (uint256 n = 0; n < totalTeachers; n++) {
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
usdc.safeTransfer(principal, principalPay);
+ emit Graduated(_levelTwo);
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
no event
Event not emitted
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.