Submission Details
Severity:
Missing _disableInitializers() calling in the implementations' constructor
Summary && Vulnerability Details
The contracts which are implementations that the proxies will point to, should call _disableInitializers() in their constructor but they are not doing it .
Impact
it is vulnerable to unintended initialization of the implementation (logic) contract, which can break upgradeability and corrupt future proxy deployments.
Tools Used
OpenZeppelin UUPS contracts
Recommendations
Adding _disableInitializers() would help mitigate this risk by locking the initializer functions.
/// @custom:oz-upgrades-unsafe-allow constructor
constructor() {
_disableInitializers(); // constructors are not used in upgradeable contracts. this is best practice to prevent initializers from happening in the constructor
}
Updates
Lead Judging Commences
yeahchibyke 17 days ago
Submission Judgement Published Assigned finding tags:
contract can be re-initialized
The system can be re-initialized by an attacker and its integrity tampered with due to lack of `disableInitializer()`
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.