Submission Details
Impact:
Likelihood:
Inconsistent wage constants between implementations cause confusion
Description:
The LevelOne and LevelTwo contracts define different wage constants for teachers, but only those in LevelOne are actually used for payments. This creates confusion and makes the code less maintainable.
// In LevelOne.sol
uint256 public constant TEACHER_WAGE = 35; // 35%
uint256 public constant PRINCIPAL_WAGE = 5; // 5%
// In LevelTwo.sol
uint256 public constant TEACHER_WAGE_L2 = 40; // Never used
uint256 public constant PRINCIPAL_WAGE_L2 = 5; // Never used
Impact:
Confusion for developers and auditors reviewing the code
Misleading constants that suggest a different payment structure than what's actually implemented
Recommended Mitigation:
Since LevelTwo is the final implementation and no further payments will be made using these constants, they should either be removed or aligned with the values in LevelOne
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.