Submission Details
Severity:
Missing Review Count Update in `giveReview`
Vulnerability Details
The giveReview function allows teachers to submit weekly reviews on students. However, the function does not increment reviewCount[_student], even though it checks that the student hasn’t been reviewed more than 5 times.
Impact
-
A teacher can submit infinite reviews for a student since reviewCount[_student] is never incremented.
-
The require(reviewCount[_student] < 5, ...) check becomes meaningless.
Recommendations
reviewCount[_student]++;
Updates
Lead Judging Commences
yeahchibyke 3 months ago
Submission Judgement Published Assigned finding tags:
reviewCount not updated
`reviewCount` for students is not updated after each review session
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.