Hawk High

summary

Unfair pay for the teachers

vulnerability details

Before going throught we need to fix the below two

-> https://codehawks.cyfrin.io/c/2025-05-hawk-high/s/cmacs89qh000hjm04f74rhroo

-> https://codehawks.cyfrin.io/c/2025-05-hawk-high/s/cmae90mc70005jx04wy6m8ob7

we have no time restrictions in the LevelOne::addTeacher where principal can add teacher once the session starts , consider two teachers where the first teacher have joined in the 1st week of the school and second teacher have joined in the last week , when principal graduating LevelOne::graduateAndUpgrade the students we are giving same pay for both the teachers

if we are going to give 100 usdc for each teacher at the end of the session

-> 1st teacher - serves 4 weeks in school - got 100 usdc

-> 2nd teacher - serves 1 week in school - got 100 usdc

if we can see the pay and the number of weeks served , it is unfair

impact - High

likelyhood - Medium

Recommendations

from the total 35% pay for the teachers , we need to divide it by the total number of days/weeks served by the teachers and need to pay each teacher based on the amount of time they have served