Hawk High

Summary

LevelOne::giveReview function fails to handle positive reviews, which means student scores can only decrease. This prevents fair score evaluation and restricts students from improving their performance metrics within the system.

Vulnerability Details

In the current implementation of the review system, only negative reviews are handled within the `giveReview` function. When a teacher submits a review, the logic only accounts for reducing the student’s score. There is no conditional logic or state update to reflect a positive review, such as increasing the student’s score or marking progress.

POC:

Add the code at the top of LevelOneAndGraduateTest.t.sol.

after that add the function in the same file.

Impact

The lack of handling for positive reviews means students' scores can only decrease, preventing any possibility of score recovery or improvement. As a result:

• Students may be unfairly blocked from graduating, even after receiving multiple positive reviews.

• The system becomes unbalanced and biased, leading to poor user experience and potential loss of trust in the platform.

  
  

Tools Used

Foundry- Manual Testing

Recommendations

Complete the if statement with following code.