Submission Details
Impact:
Likelihood:
MIssing event in fee collection
Root + Impact
Description
-
When calling
collectFeean eventFeeCollectedis emitted -
There is no such emission of the event, but the event is declared in the contract
event FeeCollected();
function collectFee() external onlyCollector {
uint256 collection = i_weth.balanceOf(address(this));
i_weth.transfer(s_collector, collection);
(bool collected,) = payable(s_collector).call{value: address(this).balance}("");
require(collected, "Fee collection failed!!!");
// @audit LOW Emitting an event to notify the fee collection
}
Risk
Likelihood:
High as it will happen always
Impact:
Low as probably is information that can be extracted from the WETH/ETH transfer anyway
Proof of Concept
Not neccessary
--
Recommended Mitigation
Include the event emission in the function
function collectFee() external onlyCollector {
uint256 collection = i_weth.balanceOf(address(this));
i_weth.transfer(s_collector, collection);
(bool collected,) = payable(s_collector).call{value: address(this).balance}("");
require(collected, "Fee collection failed!!!");
emit FeeCollected()
}
Rewards breakdown
nSLOC
215This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.