Submission Details
Impact:
Likelihood:
Missing event emission in `earnSnow`
Root + Impact
Description
-
When calling
earnSnowand event is emitted to signal it -
There is no such event emission in the function
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
s_earnTimer = block.timestamp;
// @audit LOW - Missing emission of event
}
Risk
Likelihood:
It will happen always
Impact:
Low as the information could be gathered from the Snow contract minting event
Proof of Concept
Not necessary
--
Recommended Mitigation
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
// @audit LOW - Just one wei minted in this case, seems weird
_mint(msg.sender, 1);
s_earnTimer = block.timestamp;
emit SnowEarned(msg.sender, 1);
}
Rewards breakdown
nSLOC
215This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.