Submission Details
Impact:
Likelihood:
Misleading natspec in FestivalPass::withdraw function
Misleading natspec comment in FestivalPass::withdraw function
Description
According to the natspec comment in
FestivalPass::withdraw function, organizer withdraws ETH. But function is callable by owner only which depicts that natspec comment is misleading and can create confusion
-
Function can be called by Owner only and target is set to be Organizer
-
This is an silly comment that can led to confusion
@> // Organizer withdraws ETH
function withdraw(address target) external onlyOwner {
payable(target).transfer(address(this).balance);
}
Risk
Likelihood: low
Impact: low
Recommended Mitigation
+ // Organizer recieves ETH
- // Organizer withdraws ETH
function withdraw(address target) external onlyOwner {
payable(target).transfer(address(this).balance);
}
Rewards breakdown
nSLOC
234This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.