Submission Details
Impact:
Likelihood:
the allowed tokens like weth, wbtc,wsol are stored like individual variables in the ```constructor``` which is not scalable and Repetitive boilerplate logic, Can’t loop through them efficiently
Root + Impact
Description
-
Not scalable (what if you add 10 tokens?)
-
-
Repetitive boilerplate logic
-
Can’t loop through them efficiently
// Root cause in the codebase with @> marks to highlight the relevant section
Risk
Likelihood:
-
Reason 1 // Describe WHEN this will occur (avoid using "if" statements)
-
Reason 2
Impact:
-
Impact 1
-
Impact 2
Proof of Concept
constructor(address _weth, address _wbtc, address _wsol, address _usdc, address _owner) Ownable(_owner) {
Recommended Mitigation
- constructor(address _weth, address _wbtc, address _wsol, address _usdc, address _owner) Ownable(_owner) {
+ address[] public supportedTokens;
+mapping(string => address) public tokens; // e.g., tokens["weth"]
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.