Submission Details
Impact:
Likelihood:
Redundant/ misleading status assignment in getOrderDetailsString()
Root + Impact
The getOrderDetailsString() at function inside OrderBook.sol has redundant logic for computing the status string.
-
Describe the normal behavior in one or more sentences: The normal behavior is to assign a status regarding if the order is active and the deadline is met.
-
The initial ternary assignment is completely overwritten which is pointless
string memory status = order.isActive
? (block.timestamp < order.deadlineTimestamp ? "Active" : "Expired (Active but past deadline)")
: "Inactive (Filled/Cancelled)");
if (order.isActive && block.timestamp >= order.deadlineTimestamp) {
status = "Expired (Awaiting Cancellation)";
} else if (!order.isActive) {
status = "Inactive (Filled/Cancelled)";
} else {
status = "Active";
}
Risk
Likelihood:
-
This code runs every time a user calls
getOrderDetailsString() -
The ternary condition is misleading and unused — could confuse developers or auditors.
Impact:
-
Gas inefficiency
-
Confusing or inaccurate order status display
Proof of Concept
string memory status = order.isActive
? (block.timestamp < order.deadlineTimestamp ? "Active" : "Expired (Active but past deadline)")
: "Inactive (Filled/Cancelled)";
status; // This is overwritten below regardless of condition
Recommended Mitigation
- string memory status = order.isActive
- ? (block.timestamp < order.deadlineTimestamp ? "Active" : "Expired (Active but past deadline)")
- : "Inactive (Filled/Cancelled)";
+ string memory status;
+ if (!order.isActive) {
+ status = "Inactive";
+ } else if (block.timestamp >= order.deadlineTimestamp) {
+ status = "Expired";
+ } else {
+ status = "Active";
+ }
Updates
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.