Submission Details
Impact:
Likelihood:
[G-1] The `InvalidAddress` error will never be triggered and can be removed
Author Revealed upon completion
The InvalidAddress error will never be triggered and can be removed
Description
The mintNft function is checking if the msg.sender is the zero address, and reverts in this case. However, a transaction can only be sent by an EOA or a contract account. For this reason, the assertion msg.sender == address(0) will never be true. The requirement is consuming gas on every mint for no reason.
@> error InvalidAddress();
Recommended Mitigation
Remove the InvalidAddress error:
- error InvalidAddress();
...
function mintNft() external payable onlyWhenRevealed onlyWhitelisted {
- if (msg.sender == address(0)) revert InvalidAddress();
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.