Submission Details
Impact:
Likelihood:
[G-2] Metadata state variables implementation is redundant and can be removed
Metadata state variables implementation is redundant and can be removed
Description
The contract implements 3 state variables that can be removed:
string public collectionName: already accessible with thenamepublic function inherited fromERC721.string public tokenSymbol: already accessible with thesymbolpublic function inherited fromERC721.bool public metadataFrozen: this variable is declared but never used, it should definitely be removed.
Storing and initializing these variables in the constructor is inflating the creation bytecode size, causing higher deployment gas cost.
@> string public collectionName;
@> string public tokenSymbol;
@> bool public metadataFrozen;
Recommended Mitigation
Delete the 3 state variables:
- string public collectionName;
- string public tokenSymbol;
- bool public metadataFrozen;
constructor(
address _owner,
address _usdc,
string memory _collectionName,
string memory _symbol,
string memory _collectionImage,
uint256 _lockAmount
) ERC721(_collectionName, _symbol) {
owner = _owner;
usdc = IERC20(_usdc);
- collectionName = _collectionName;
- tokenSymbol = _symbol;
collectionImage = _collectionImage;
lockAmount = _lockAmount;
}
Updates
Lead Judging Commences
rubik0n 16 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Invalid
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.